note re commit 09e5440b69906b3b325203521c851c06f3ce4fa3
Hi Johannes, Just a note. We run the test suite in parallel. Since conditional_forecast saves its output to a file "conditional_forecast.mat", this poses a problem for checking the values in this file when there are more than one .mod file in a directory that call conditional_forecast as the .mat file can be overwritten. Thus the test suite said that there was a problem with conditional_forecasts/fs2000_conditional_forecast_initval.mod when there wasn't. For now, I have fixed this by moving each of these .mod files to its own directory. This problem could also be fixed by saving "conditional_forecasts.mat" to <<modfilebasename>>/conditional_forecats.mat or <<modfilebasename>>_conditional_forecasts.mat. I did not make this change as I felt it would require a discussion on the list. In any case, please keep this in mind for future tests that you may add to the test suite. Best, Houtan
Hi Houtan, thanks a lot. I would very much support changing the saving of the conditional forecasts as it deviates from the practice of all other outputs and is prone to errors. I would propose saving to <<modfilebasename>>/Output/conditional_forecats.mat Best, Johannes Am 09.09.2015 um 10:54 schrieb Houtan Bastani:
Hi Johannes,
Just a note. We run the test suite in parallel. Since conditional_forecast saves its output to a file "conditional_forecast.mat", this poses a problem for checking the values in this file when there are more than one .mod file in a directory that call conditional_forecast as the .mat file can be overwritten. Thus the test suite said that there was a problem with conditional_forecasts/fs2000_conditional_forecast_initval.mod when there wasn't.
For now, I have fixed this by moving each of these .mod files to its own directory.
This problem could also be fixed by saving "conditional_forecasts.mat" to <<modfilebasename>>/conditional_forecats.mat or <<modfilebasename>>_conditional_forecasts.mat. I did not make this change as I felt it would require a discussion on the list.
In any case, please keep this in mind for future tests that you may add to the test suite.
Best, Houtan _______________________________________________ Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
Sorry that was not supposed to be addressed to Johannes but to everyone. On 09/09/2015 10:54 AM, Houtan Bastani wrote:
Hi Johannes,
Just a note. We run the test suite in parallel. Since conditional_forecast saves its output to a file "conditional_forecast.mat", this poses a problem for checking the values in this file when there are more than one .mod file in a directory that call conditional_forecast as the .mat file can be overwritten. Thus the test suite said that there was a problem with conditional_forecasts/fs2000_conditional_forecast_initval.mod when there wasn't.
For now, I have fixed this by moving each of these .mod files to its own directory.
This problem could also be fixed by saving "conditional_forecasts.mat" to <<modfilebasename>>/conditional_forecats.mat or <<modfilebasename>>_conditional_forecasts.mat. I did not make this change as I felt it would require a discussion on the list.
In any case, please keep this in mind for future tests that you may add to the test suite.
Best, Houtan _______________________________________________ Dev mailing list Dev@dynare.org https://www.dynare.org/cgi-bin/mailman/listinfo/dev
participants (2)
-
Houtan Bastani -
Johannes Pfeifer